Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that #[deny(allow_attributes)] do not issue spurious messages #13389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samueltardieu
Copy link
Contributor

Add a new test for #13380. This bug was caused by a bug in rustc which has been fixed in rust-lang/rust@6ee87ae.

Close #13380

changelog: [allow_attributes]: fix spurious warning messages

@rustbot
Copy link
Collaborator

rustbot commented Sep 12, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 12, 2024
@samueltardieu
Copy link
Contributor Author

samueltardieu commented Sep 12, 2024

This PR will stay in draft stage until Clippy is synchronized with the latest compiler sources. It will fail until then.

@samueltardieu
Copy link
Contributor Author

samueltardieu commented Sep 22, 2024

@xFrednet The test is now ready to be added, the rustc merge has happened and the bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow_attributes triggers on variable name
3 participants